Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore fetch test cases #1535

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Restore fetch test cases #1535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions js/fetch_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,26 +135,6 @@ testPerm({ net: true }, async function fetchInitBlobBody() {
assert(response.headers.get("content-type").startsWith("text/javascript"));
});

// TODO(ry) The following tests work but are flaky. There's a race condition
// somewhere. Here is what one of these flaky failures looks like:
//
// test fetchPostBodyString_permW0N1E0R0
// assertEqual failed. actual = expected = POST /blah HTTP/1.1
// hello: World
// foo: Bar
// host: 127.0.0.1:4502
// content-length: 11
// hello world
// Error: actual: expected: POST /blah HTTP/1.1
// hello: World
// foo: Bar
// host: 127.0.0.1:4502
// content-length: 11
// hello world
// at Object.assertEqual (file:///C:/deno/js/testing/util.ts:29:11)
// at fetchPostBodyString (file

/*
function bufferServer(addr: string): deno.Buffer {
const listener = deno.listen("tcp", addr);
const buf = new deno.Buffer();
Expand Down Expand Up @@ -187,6 +167,7 @@ testPerm({ net: true }, async function fetchRequest() {
});
assertEqual(response.status, 404);
assertEqual(response.headers.get("Content-Length"), "2");
await response.blob();

const actual = new TextDecoder().decode(buf.bytes());
const expected = [
Expand All @@ -209,12 +190,14 @@ testPerm({ net: true }, async function fetchPostBodyString() {
});
assertEqual(response.status, 404);
assertEqual(response.headers.get("Content-Length"), "2");
await response.blob();

const actual = new TextDecoder().decode(buf.bytes());
const expected = [
"POST /blah HTTP/1.1\r\n",
"hello: World\r\n",
"foo: Bar\r\n",
"content-type: text/plain;charset=UTF-8\r\n",
`host: ${addr}\r\n`,
`content-length: ${body.length}\r\n\r\n`,
body
Expand All @@ -234,6 +217,7 @@ testPerm({ net: true }, async function fetchPostBodyTypedArray() {
});
assertEqual(response.status, 404);
assertEqual(response.headers.get("Content-Length"), "2");
await response.blob();

const actual = new TextDecoder().decode(buf.bytes());
const expected = [
Expand All @@ -246,4 +230,3 @@ testPerm({ net: true }, async function fetchPostBodyTypedArray() {
].join("");
assertEqual(actual, expected);
});
*/