fix: Update Object.prototype.__proto__ related comments
#15394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
reviewed
Aug 3, 2022
cli/tsc/99_main_compiler.js
Outdated
| @@ -9,7 +9,7 @@ | |||
| // instances convert TypeScript to JavaScript. | |||
|
|
|||
| // Removes the `__proto__` for security reasons. This intentionally makes | |||
| // Deno non compliant with ECMA-262 Annex B.2.2.1 | |||
| // Deno non compliant with ECMA-262 20.1.3.8 | |||
There was a problem hiding this comment.
How is Deno non-compliant if the __proto__ accessor is normative optional?
There was a problem hiding this comment.
oops! How about just removing it? @littledivy
Suggested change
| // Deno non compliant with ECMA-262 20.1.3.8 |
There was a problem hiding this comment.
or just specify like this
Suggested change
| // Deno non compliant with ECMA-262 20.1.3.8 | |
| // https://tc39.es/ecma262/#sec-get-object.prototype.__proto__ |
There was a problem hiding this comment.
I've fixed this and decided not to change comment in testdata! thanks :) @littledivy
hyp3rflow
force-pushed
the
fix/proto-comment
branch
from
98dd426 to
3f07453
Compare
littledivy
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #14864 (comment) mentioned, Update comments pointing
Object.prototype.__proto__in ECMA262Related ECMA262 PR: tc39/ecma262#2125