Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --inspect-wait flag #17001

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Dec 9, 2022

This commit adds new "--inspect-wait" flag which works similarly
to "--inspect-brk" in that it waits for inspector session to be
established before running code. However it doesn't break on the first
statement of user code, but instead runs it as soon as a session
is established.

Closes denoland/vscode_deno#755

@bartlomieju bartlomieju changed the title feat: Add --inspect-wait flag [WIP] feat: Add --inspect-wait flag Dec 9, 2022
@bartlomieju bartlomieju changed the title [WIP] feat: Add --inspect-wait flag feat: Add --inspect-wait flag Dec 9, 2022
@bartlomieju bartlomieju requested a review from dsherret December 9, 2022 23:02
@bartlomieju bartlomieju added this to the 1.29 milestone Dec 10, 2022
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret changed the title feat: Add --inspect-wait flag feat: add --inspect-wait flag Dec 12, 2022
@bartlomieju bartlomieju merged commit 4a17c93 into denoland:main Dec 12, 2022
@bartlomieju bartlomieju deleted the inspect_wait branch December 12, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launching debug still doesn't work, something always binds to 9229
2 participants