-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update webgpu #17534
chore: update webgpu #17534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the size of resulting binary produced by this change?
@@ -65,6 +76,8 @@ pub mod queue; | |||
pub mod render_pass; | |||
pub mod sampler; | |||
pub mod shader; | |||
#[cfg(feature = "surface")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it hidden behind a feature flag? Is this flag on by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no its disabled by default. its not important directly to cli, but for other projects
seems to be about 0.3 mb less than main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #10098
Fixes #12721
Closes #17580