Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update webgpu #17534

Merged
merged 6 commits into from
Jan 30, 2023
Merged

chore: update webgpu #17534

merged 6 commits into from
Jan 30, 2023

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jan 26, 2023

Fixes #10098
Fixes #12721
Closes #17580

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the size of resulting binary produced by this change?

ext/webgpu/Cargo.toml Outdated Show resolved Hide resolved
@@ -65,6 +76,8 @@ pub mod queue;
pub mod render_pass;
pub mod sampler;
pub mod shader;
#[cfg(feature = "surface")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it hidden behind a feature flag? Is this flag on by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no its disabled by default. its not important directly to cli, but for other projects

@crowlKats
Copy link
Member Author

What's the size of resulting binary produced by this change?

seems to be about 0.3 mb less than main

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 3035dee into denoland:main Jan 30, 2023
@crowlKats crowlKats deleted the update_webgpu branch January 30, 2023 14:37
jbatez pushed a commit to denogdev/denog that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants