Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental decorators #1859

Closed
wants to merge 2 commits into from

Conversation

afinch7
Copy link
Contributor

@afinch7 afinch7 commented Feb 28, 2019

Added an option to enable experimental decorators for the typescript compiler.
I've also added in some room for other user configurable compiler options.

@bartlomieju
Copy link
Member

bartlomieju commented Feb 28, 2019

We were pretty conservative about adding command line arguments, so it might not be a good idea to add another flag just for TS option.

Also @kitsonk might be interested, I think he wanted to add custom compiler configs, but it was on hold due to recent compiler refactors.

@afinch7
Copy link
Contributor Author

afinch7 commented Feb 28, 2019

Is there some existing code for the compiler refactors, because I would like to give some input on that.

@afinch7
Copy link
Contributor Author

afinch7 commented Feb 28, 2019

On closer review I realized that if we change the compiler options deno won't automatically recompile the source unless it has changed. It will just use the last successful build unless the source changes.

Put this one on indefinite hold I would rather invest time into getting a better system into a new compiler than continue down this road right now.

@kitsonk
Copy link
Contributor

kitsonk commented Mar 1, 2019

This should only be supported via supporting tsconfig.json in my opinion. See #51.

The existing compiler refactors is largely done. There is this issue #1738 which is what I am working on now, which I wanted to do before we tackled #51 (thought not directly related). There is the restoring of compiler unit tests which we don't have a specific issue for, but it is a rather complex thing, which is directly related to the rewrite of Deno core though (as we need to create a build that loads the compiler isolate and executes the tests within that isolate). Adding in the customer tsconfig.json support (or any other compiler feature) really needs that.

@afinch7
Copy link
Contributor Author

afinch7 commented Mar 1, 2019

@kitsonk Yep I think we are pretty much one the same page with this one. I submitted it and almost immediately had regrets, but I did make some useful discoveries. The most important thing I noted working on this is the ts language service doesn't need to reinitialized to update some settings. That means that at least some compiler settings can be changed without a huge cost to startup time. I'm going to close this one for now.

@afinch7 afinch7 closed this Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants