Add test style guide #1918
Merged
Add test style guide #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Mar 12, 2019
ry
reviewed
Mar 12, 2019
ry
reviewed
Mar 12, 2019
website/style_guide.md
Outdated
| import { assertStrContains } from "https://deno.land/std@v0.3.1/testing/asserts.ts"; | ||
| import { test } from "https://deno.land/std@v0.3.1/testing/mod.ts"; | ||
|
|
||
| test(function testingAssertStringContains() { |
There was a problem hiding this comment.
Maybe the name of the function here should correspond to the output you give above?
There was a problem hiding this comment.
Didn't thought about it but yes
ry
reviewed
Mar 13, 2019
website/style_guide.md
Outdated
| } catch (e) { | ||
| didThrow = true; | ||
| } | ||
| assertEquals(didThrow, true); |
There was a problem hiding this comment.
Please use a smaller one line example with just a single assertEquals... I think all this code distracts from the point the style guide is making. This isn't documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving style guide for tests as mentionned in : denoland/std#130