Integrate src/ with core/ #1919
Conversation
This is in preperation for core integration.
core: Add deno_core::Behavior trait to control Isolate Adds basic ES module bindings to deno_core::Isolate. clean up respond should be private startup_shared and startup_snapshot Add v8_set_flags to core core: add v8_version() core: api adjustments deno builds on core Behavior should be queue instead of stack WIP msg_ring WIP: use msg_ring sync core integration: Support mod_execute reset properly Fix module registration core int: impl handleAsyncMsgFromRust and worker adjustments Add reset logging Fix msg_ring async receive bug use split buffer Remove reset cruft Implement resolve callback for Cli Behavior fix rebase
src/cli.rs
Outdated
| state: Arc<IsolateState>, | ||
| permissions: DenoPermissions, | ||
| ) -> Self { | ||
| let buffer = msg_ring::Buffer::new(1024 * 1024); |
There was a problem hiding this comment.
This buffer is too small for some tests to complete. Might need a redesign.
Changing it to 1024 * 8196 bytes(~8MB) get us past the current failure, but errors out on a later test with:
tests/error_004_missing_module.test ... FAILED
Expected output does not match actual.
Expected output:
Compiling [WILDCARD]tests/error_004_missing_module.ts
Uncaught NotFound: Cannot resolve module "bad-module.ts" from "[WILDCARD]/tests/error_004_missing_module.ts"
at DenoError ([WILDCARD]/js/errors.ts:[WILDCARD])
at maybeError ([WILDCARD]/js/errors.ts:[WILDCARD])
at maybeThrowError ([WILDCARD]/js/errors.ts:[WILDCARD])
at sendSync ([WILDCARD]/js/dispatch.ts:[WILDCARD])
at fetchModuleMetaData ([WILDCARD]/js/os.ts:[WILDCARD])
at _resolveModule ([WILDCARD]/js/compiler.ts:[WILDCARD])
at resolveModuleNames ([WILDCARD]/js/compiler.ts:[WILDCARD])
at compilerHost.resolveModuleNames ([WILDCARD]typescript.js:[WILDCARD])
at resolveModuleNamesWorker ([WILDCARD]typescript.js:[WILDCARD])
at resolveModuleNamesReusingOldState ([WILDCARD]typescript.js:[WILDCARD])
Actual output:
Compiling file:///home/andy/Documents/projects/personal/deno/tests/error_004_missing_module.ts
Uncaught NotFound: Cannot resolve module "bad-module.ts" from "/home/andy/Documents/projects/personal/deno/tests/error_004_missing_module.ts"
at DenoError (deno/js/errors.ts:22:5)
at maybeError (deno/js/errors.ts:33:12)
at maybeThrowError (deno/js/errors.ts:39:15)
at sendSync (deno/js/dispatch.ts:87:5)
at fetchModuleMetaData (deno/js/os.ts:81:19)
at _resolveModule (deno/js/compiler.ts:249:38)
at resolveModuleNames (deno/js/compiler.ts:479:35)
at compilerHost.resolveModuleNames (deno/third_party/node_modules/typescript/lib/typescript.js:118650:138)
at resolveModuleNamesWorker (deno/third_party/node_modules/typescript/lib/typescript.js:86767:127)
at resolveModuleNamesReusingOldState (deno/third_party/node_modules/typescript/lib/typescript.js:87001:24)thread '
tokio-runtime-worker-0' panicked at 'called `Result::unwrap()` on an `Err` value: DenoError { repr: Simple(BadResource, "bad resource id") }', src/libcore/result.rs:997:5
This other error is unrelated.
There was a problem hiding this comment.
Ah - thanks! I want to get the error messages when this happens to be more useful...
There was a problem hiding this comment.
It looks like this might become problematic. The record that failed in that test was smaller than 1048576 bytes, so it was likely caused by a chain of blocking operations. At what point are records removed from the buffer here(I assume that is what records_shift is for)? Could this garbage collection potentially be blocked by chain operations long enough to fill the buffer(I.E. lots of imports in a single file)?
There was a problem hiding this comment.
Did some debugging, and I think I have this next one figured out. Not sure how you want't to solve it, but It looks like compile_sync needs a valid failure mode other than thread panic or js errors in workers need to handled by the worker instantiater(compile_sync in this case). I like the later better. A failure in a webworker shouldn't cause deno to exit, that's not how a browser would handle it. The instantiater should be able to decide if the worker failure is a fatal failure or not.
| @@ -94,7 +93,9 @@ pub fn compile_sync( | |||
| send_future.wait().unwrap(); | |||
|
|
|||
| let recv_future = resources::worker_recv_message(compiler.rid); | |||
| let res_msg = recv_future.wait().unwrap().unwrap(); | |||
| let result = recv_future.wait().unwrap(); | |||
There was a problem hiding this comment.
The next error I run into in tests is pretty complicated. For some reason we end up with a thread panic in the middle of our file not found error print out:
Compiling file:///home/andy/Documents/projects/personal/deno/tests/error_004_missing_module.ts
thread 'Uncaught NotFound: Cannot resolve module "bad-module.ts" from "/home/andy/Documents/projects/personal/deno/tests/error_004_missing_module.ts"
at DenoError (deno/js/errors.ts:22:5)
at maybeError (deno/js/errors.ts:33:12)
at maybeThrowError (deno/js/errors.ts:39:15)
at sendSync (deno/js/dispatch.ts:87:5)
at fetchModuleMetaData (deno/js/os.ts:81:19)
at _resolveModule (deno/js/compiler.ts:249:38)
at resolveModuleNames (deno/js/compiler.ts:479:35)
at compilerHost.resolveModuleNames (deno/third_party/node_modules/typescript/lib/typescript.js:118650:138)
at resolveModuleNamesWorker (deno/third_party/node_modules/typescript/lib/typescript.js:86767:127)
at resolveModuleNamesReusingOldState (deno/third_party/node_modules/typescript/lib/typescript.js:87001:24)tokio-runtime-worker-0
' panicked at 'called `Result::unwrap()` on an `Err` value: DenoError { repr: Simple(BadResource, "bad resource id") }', src/libcore/result.rs:997:5
It's not really a problem for end users, but it just makes it very difficult to test expected failures. The best way to replicate this one is with target/release/deno tests/error_004_missing_module.ts --reload.
It looks like the thread that compile_sync is running in manages to panic here before we finish our error print and exit in workers.rs.
|
closed in favor of #1938 |
tests still not passing completely.
Depends on #1915