Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ license = "MIT"
repository = "https://github.com/denoland/deno"

[workspace.dependencies]
deno_ast = { version = "0.29.1", features = ["transpiling"] }
deno_ast = { version = "0.29.3", features = ["transpiling"] }

deno_core = { version = "0.211.0" }

Expand Down
5 changes: 5 additions & 0 deletions cli/tests/integration/run_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4701,3 +4701,8 @@ console.log(returnsHi());"#,
")
.assert_exit_code(1);
}

itest!(explicit_resource_management {
args: "run --quiet --check run/explicit_resource_management/main.ts",
output: "run/explicit_resource_management/main.out",
});
5 changes: 5 additions & 0 deletions cli/tests/testdata/run/explicit_resource_management/main.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
A
Disposed
B
Async disposed
C
21 changes: 21 additions & 0 deletions cli/tests/testdata/run/explicit_resource_management/main.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
class Resource {
[Symbol.dispose]() {
console.log("Disposed");
}
}
class AsyncResource {
async [Symbol.asyncDispose]() {
await new Promise((resolve) => setTimeout(resolve, 10));
console.log("Async disposed");
}
}

{
using resource = new Resource();
console.log("A");
}
{
await using resource = new AsyncResource();
console.log("B");
}
console.log("C");
5 changes: 5 additions & 0 deletions runtime/js/99_main.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ import {
workerRuntimeGlobalProperties,
} from "ext:runtime/98_global_scope.js";

// deno-lint-ignore prefer-primordials
Symbol.dispose ??= Symbol("Symbol.dispose");
// deno-lint-ignore prefer-primordials
Symbol.asyncDispose ??= Symbol("Symbol.asyncDispose");

let windowIsClosing = false;
let globalThis_;

Expand Down