feat(streams): ReadableStream.read min option #20849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: whatwg/streams#1145 has just landed. 😉 |
This was referenced Nov 13, 2023
# Conflicts: # ext/web/06_streams.js
Merged
crowlKats
added a commit
that referenced
this pull request
Nov 13, 2023
kt3k
pushed a commit
that referenced
this pull request
Nov 17, 2023
kt3k
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
LGTM
(The diff looks almost identical to the diff of the reference implementation in whatwg/streams#1145 )
zifeo
pushed a commit
to metatypedev/deno
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements whatwg/streams#1145. Have to wait for WPT to land first (web-platform-tests/wpt#29723). Needed for denoland/std#1985