refactor (parseCssColor): use parseInt, avoid unnecessary coercion

[ljharb]

Upstream some changes from nodejs/node#49205

[CLAassistant]

All committers have signed the CLA.

[bartlomieju]

Thanks for the PR @ljharb; any chance you could update cli/tests/node_compat/test/parallel/test-util-format.js to include the tests from PR in Node repo?

[ljharb]

Sure, i'll have to clone the repo so give me a few days.

[lucacasonato]

LGTM

[lucacasonato]

FYI to other reviewers: safe because SafeMap, but may result in prefer-primordials linter errors. Let's see :)

EDIT: linter is happy :)

[lucacasonato]

@bartlomieju NO_COLOR seems to be enabled in the node compat tests, so the tests don't pass. PTAL

[ljharb]

@bartlomieju actually these are just refactors and have nothing to do with the meat of the node PR; what tests would you want me to include?

[bartlomieju]

@ljharb, oh I thought these tests were checking this change:

assert.strictEqual(
  util.formatWithOptions({ colors: true }, '%cfoo', 'color: red'),
  '\x1b[31mfoo\x1b[0m'
);

assert.strictEqual(
  util.formatWithOptions(
    { colors: true },
    '%cfoo',
    'color: red; background-color: blue'
  ),
  '\x1B[44m\x1B[31mfoo\x1B[0m'
);

assert.strictEqual(
  util.formatWithOptions({ colors: true }, '%cfoo', 'color: red', 'bar'),
  '\x1b[31mfoo\x1b[0m bar'
);

assert.strictEqual(
  util.formatWithOptions({ colors: true }, '%cfoo%c bar', 'color: red', ''),
  '\x1b[31mfoo\x1b[39m bar\x1b[0m'
);

assert.strictEqual(
  util.formatWithOptions(
    { colors: true },
    '%cfoo %cbar',
    'color: red',
    'color: blue'
  ),
  '\x1b[31mfoo \x1b[34mbar\x1b[0m'
);

I'll take a look at the CI failure.

[ljharb]

any update? These are just simple refactors to improve the code quality and potentially performance.

[bartlomieju]

Sorry for a slow response @ljharb. I revert that test file change as running update scripts for Node compat tests causes them to be removed anyway. Thanks, LGTM

[ljharb]

Thanks!