chore: add aarch64-apple-darwin builds to ci #21243
Conversation
.github/workflows/ci.generate.ts
Outdated
| "(github.repository == 'denoland/deno' &&", | ||
| "(github.ref == 'refs/heads/main' ||", | ||
| "startsWith(github.ref, 'refs/tags/'))))", | ||
| "(github.repository == 'denoland/deno')))", |
There was a problem hiding this comment.
The skip_pr flag already controls this, so this change allows us to test release builds without pushing to main
| @@ -718,7 +738,7 @@ const ci = { | |||
| name: "Test debug (fast)", | |||
| if: [ | |||
| "matrix.job == 'test' && matrix.profile == 'debug' &&", | |||
| "!startsWith(matrix.os, 'ubuntu')", | |||
| "(startsWith(github.ref, 'refs/tags/') || !startsWith(matrix.os, 'ubuntu'))", | |||
There was a problem hiding this comment.
We were skipping test debug on ubuntu for tag builds
There was a problem hiding this comment.
I believe this was done on purpose to limit CI run time for tags.
There was a problem hiding this comment.
It's a bit odd because we run the fast tests on every other platform, but ubuntu (the fastest runner) doesn't. It kind of feels like an accidental bit of logic.
|
Oh wait, that seems to be the case in the workflow run. I forget how this code works. |
dsherret
changed the title
| profile: "release", | ||
| // TODO(mmastrac): We don't want to run this M1 runner on every main commit because of the expense. | ||
| skip: | ||
| "${{ github.event_name == 'pull_request' || github.ref == 'refs/heads/main' }}", |
There was a problem hiding this comment.
Nice! In the future, perhaps we could have this also run infrequently on main.
There was a problem hiding this comment.
We might be able to do something silly like "if commit ID ends in zero, run aarch64 build"
This is a prerequisite to automatic code signing.
This is a prerequisite to automatic code signing. (cherry picked from commit 93c4c1a)
This is a prerequisite to automatic code signing.
This is a prerequisite to automatic code signing.