Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node_compat test suites to v18.18.2 #21328

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 24, 2023

This PR updates node compat test cases to Node.js v18.18.2.

test-buffer-copy.js and test-stream-duplex-from.js need to be added to ignore list because these 2 files include newly failing test cases, which are commented out in this PR.

closes #21306

@kt3k kt3k requested a review from bartlomieju November 24, 2023 12:11
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please open separate issues for the two failing tests?

@kt3k
Copy link
Member Author

kt3k commented Nov 25, 2023

can you please open separate issues for the two failing tests?

Sure! #21335 #21336

@kt3k kt3k merged commit 5710fff into denoland:main Nov 25, 2023
14 checks passed
@kt3k kt3k deleted the update-node-compat-test branch November 25, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update node compat test suite
2 participants