Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): UdpSocket ref and unref #21777

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

littledivy
Copy link
Member

Fixes #20138

Different implementation than #21521 (cc @CosminPerRam)

@littledivy littledivy requested a review from bartlomieju January 3, 2024 16:10
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@littledivy littledivy merged commit ad65440 into denoland:main Jan 4, 2024
14 checks passed
@littledivy littledivy deleted the node_dgram_refunref branch January 4, 2024 03:21
@kt3k kt3k mentioned this pull request Nov 26, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Not implemented: udp.UDP.prototype.unref
2 participants