Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade to deno_ast 0.33 #22341

Merged
merged 5 commits into from
Feb 9, 2024
Merged

fix: upgrade to deno_ast 0.33 #22341

merged 5 commits into from
Feb 9, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 8, 2024 •
edited
Loading

Closes #22117
Closes #22109
Closes #21927
Closes #20993

@dsherret dsherret marked this pull request as ready for review February 8, 2024 23:42
dsherret
dsherret commented Feb 8, 2024
View reviewed changes
cli/tests/testdata/lint/expected_from_stdin_json.out
@@ -1,6 +1,7 @@
{
"diagnostics": [
{
"filename": "[WILDCARD]$deno$stdin.ts",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it reads better when it's above the range.

@dsherret dsherret changed the title refactor: upgrade to deno_ast 0.33 fix: upgrade to deno_ast 0.33 Feb 8, 2024
lucacasonato
lucacasonato approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret enabled auto-merge (squash) February 8, 2024 23:57
@dsherret dsherret merged commit e5e2c45 into denoland:main Feb 9, 2024
20 checks passed
@dsherret dsherret deleted the deno_ast_0_33 branch February 9, 2024 02:04
littledivy pushed a commit that referenced this pull request Feb 15, 2024
@dsherret @littledivy
fix: upgrade to deno_ast 0.33 (#22341)
019fae0 
* Uses diagnostics from deno_ast
* Real fix for #22310
* Moves `deno lint --json` code here
* Upgrades swc
   
 Closes #22117
 Closes #22109
 Closes #21927
 Closes #20993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dsherret @lucacasonato