fix(lsp): decoding percent-encoding(non-ASCII) file path correctly #22582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hajime-san
commented
Feb 26, 2024
cli/lsp/documents.rs
Outdated
Comment on lines
651
to
653
| let format = |scheme: &str, rest: &str| -> String { | ||
| format!("{}​{}", scheme, rest).replace('@', "​@") | ||
| }; |
There was a problem hiding this comment.
BTW, I'm not clear to put in zero-width space👀
|
Oh, |
aapoalas
previously requested changes
Mar 5, 2024
Hajime-san
force-pushed
the
fix-lsp-filepath-percent-encoding
branch
from
d7d4c43 to
eea5b99
Compare
|
Fix with rebase! |
…string due to display non-ASCII characters
Hajime-san
force-pushed
the
fix-lsp-filepath-percent-encoding
branch
from
eea5b99 to
eee88d5
Compare
nayeemrmn
approved these changes
Mar 9, 2024
|
Thanks! |
Signed-off-by: Hajime-san <41257923+Hajime-san@users.noreply.github.com>
bartlomieju
pushed a commit
that referenced
this pull request
May 28, 2024
…ly (#23200) # Summary This PR resolves about the issue. fixes #10810 And the formerly context is in the PR. #22582 Here is an expected behaviour example with this change. - 🦕.test.ts ```ts import { assertEquals } from "https://deno.land/std@0.215.0/assert/mod.ts"; Deno.test("example test", () => { assertEquals("🍋", "🦕"); }); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
Urlalias of ModuleSpecifier type indeno_corekeeps local file path with percent-encoding string while it includes non-ASCII character like emoji.It causes unintentional completion, hover text, rename and diagnostic with percent-encoding string by lsp server.
This patch is an ad hoc approach for resolve this problem.
Expected behaviour
2024-02-26-01-c.mov
related issues
resolves #12065
resolves denoland/vscode_deno#517
There are test reporter and runtime problems.
#18983
There is a test reporter problem.
#10810
There are tsc problems.
#16058
microsoft/TypeScript#57539