chore: upgrade to reqwest 0.12.4 and rustls 0.22 #24056

bartlomieju · 2024-05-31T00:10:59Z

This commit updates Deno to use reqwest at 0.12.4
and rustls at 0.22. Other related crates were updated
as well to match versions accepted by reqwest and rustls.

Note: we are not using the latest available rustls yet,
but this upgrade was non-trivial already, so a bump to
0.23 for rustls will be done in a separate commit.

Closes #23370

Cargo.lock

Cargo.toml

ext/fetch/Cargo.toml

ext/tls/lib.rs

ext/tls/tls_key.rs

tests/wpt/suite

ext/tls/Cargo.toml

To avoid duplicate winreg crate in #24056

To avoid duplicate winreg crate in #24056 --------- Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

lucacasonato · 2024-06-06T10:50:21Z

Failing test is due to this change in hyper: seanmonstar/reqwest#2207

My two cents: seanmonstar/reqwest#2240 (comment)

~~If we land this as is, POST and PUT requests to some HTTP servers, including anything behind Google Load Balancer, probably break. As such I think we're blocked here until this is fixed in reqwest.~~

EDIT: My bad, I misinterpreted the issue - we're now adding content-length: 0 to PATCH requests that previously had no content-length. ~~It's less bad, but probably should still be reverted.~~

EDIT2: It was already reverted in hyper 1.3.1, so upgrading to that will fix this. Sorry for the noise.

ext/tls/testdata/README

tests/util/server/src/https.rs

littledivy

LGTM!

Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com> Signed-off-by: Ryan Dahl <ry@tinyclouds.org>

Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com> Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>

This commit updates Deno to use `reqwest` at 0.12.4 and `rustls` at 0.22. Other related crates were updated as well to match versions accepted by `reqwest` and `rustls`. Note: we are not using the latest available `rustls` yet, but this upgrade was non-trivial already, so a bump to 0.23 for `rustls` will be done in a separate commit. Closes #23370 --------- Signed-off-by: Ryan Dahl <ry@tinyclouds.org> Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com> Co-authored-by: Ryan Dahl <ry@tinyclouds.org> Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>

)" This reverts commit fb31eaa.

…24262) This reverts commit fb31eaa. Reverting because users reported spurious errors when downloading dependencies - #24260. Closes #24260

…oland#24056)" (denoland#24262)" This reverts commit b94707a.

Reland of #24056 that doesn't suffer from the problem that was discovered in #24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.

)" (denoland#24262) This reverts commit fb31eaa. Reverting because users reported spurious errors when downloading dependencies - denoland#24260. Closes denoland#24260

Reland of denoland#24056 that doesn't suffer from the problem that was discovered in denoland#24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.

This commit updates Deno to use `reqwest` at 0.12.4 and `rustls` at 0.22. Other related crates were updated as well to match versions accepted by `reqwest` and `rustls`. Note: we are not using the latest available `rustls` yet, but this upgrade was non-trivial already, so a bump to 0.23 for `rustls` will be done in a separate commit. Closes denoland#23370 --------- Signed-off-by: Ryan Dahl <ry@tinyclouds.org> Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com> Co-authored-by: Ryan Dahl <ry@tinyclouds.org> Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>

)" (denoland#24262) This reverts commit fb31eaa. Reverting because users reported spurious errors when downloading dependencies - denoland#24260. Closes denoland#24260

Reland of denoland#24056 that doesn't suffer from the problem that was discovered in denoland#24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.

bartlomieju and others added 9 commits May 31, 2024 01:45

wip

db0d2d2

got to deno_kv

6f2b292

Merge branch 'upgrade_denokv' into migrate_reqwest

0996394

progress, but rustls is pain

d515e01

Merge branch 'main' into migrate_reqwest

7429a83

upgrade webpki-roots, fix syntax

d3bfbd3

wip

6389b1f

progress

23b7ef1

clippy passes!

b452d2a

bartlomieju commented Jun 3, 2024

View reviewed changes

bartlomieju added 2 commits June 4, 2024 00:18

checkout wpt

c95b074

Address some todos

4c433a1

ry mentioned this pull request Jun 4, 2024

chore: upgrade to rustls 0.22 denoland/deno_native_certs#3

Merged

avoid rustls-pemfile 1.0.4 - deno_native_certs changes

697683b

ry reviewed Jun 4, 2024

View reviewed changes

ext/tls/Cargo.toml Outdated Show resolved Hide resolved

ry and others added 7 commits June 4, 2024 07:48

fix tls_key_for_test

feeb37f

Merge branch 'main' into migrate_reqwest

aa685f4

fix after merge

c94f0f9

use updated deno_native_certs 0.3.0

983a92f

fix some fetch tests

a85e876

fix some http and serve tests

4cbe97c

Merge branch 'main' into migrate_reqwest

ffde125

ry added a commit that referenced this pull request Jun 5, 2024

chore: upgrade trust-dns-resolver and friends

c9b8940

To avoid duplicate winreg crate in #24056

ry mentioned this pull request Jun 5, 2024

chore: upgrade trust-dns-resolver and friends #24108

Merged

bartlomieju added a commit that referenced this pull request Jun 5, 2024

chore: upgrade trust-dns-resolver and friends (#24108)

c789444

To avoid duplicate winreg crate in #24056 --------- Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

Merge branch 'main' into migrate_reqwest

7dbe70e

bartlomieju added 3 commits June 6, 2024 13:31

Merge branch 'main' into migrate_reqwest

bf81190

bump hyper

92e8d4b

Merge branch 'main' into migrate_reqwest

9dfb0ec

nalla mentioned this pull request Jun 12, 2024

feat: upgrade Reqwest to 0.12 [WIP] #23542

Closed

bartlomieju added 4 commits June 12, 2024 17:45

Merge branch 'main' into migrate_reqwest

80e7946

bump denokv

3b3260b

Merge branch 'main' into migrate_reqwest

1252adf

update tls code

fa416d7

bartlomieju changed the title ~~chore: upgrade to reqwest 0.12.4~~ chore: upgrade to reqwest 0.12.4 and rustls 0.22 Jun 12, 2024

Merge branch 'main' into migrate_reqwest

530c46a

littledivy reviewed Jun 13, 2024

View reviewed changes

ext/tls/testdata/README Outdated Show resolved Hide resolved

littledivy reviewed Jun 13, 2024

View reviewed changes

tests/util/server/src/https.rs Outdated Show resolved Hide resolved

littledivy approved these changes Jun 13, 2024

View reviewed changes

devsnek approved these changes Jun 13, 2024

View reviewed changes

ry and others added 3 commits June 13, 2024 09:49

Update ext/tls/testdata/README

3111746

Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com> Signed-off-by: Ryan Dahl <ry@tinyclouds.org>

Update tests/util/server/src/https.rs

3cf9d35

Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com> Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>

Merge branch 'main' into migrate_reqwest

20d2e4e

bartlomieju merged commit fb31eaa into denoland:main Jun 13, 2024
17 checks passed

bartlomieju deleted the migrate_reqwest branch June 13, 2024 20:41

bartlomieju mentioned this pull request Jun 19, 2024

fix: FileFetcher correctly retries failed requests #24261

Closed

bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jun 19, 2024

Revert "chore: upgrade to reqwest 0.12.4 and rustls 0.22 (denoland#24056

2b085a5

)" This reverts commit fb31eaa.

bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jul 1, 2024

Revert "Revert "chore: upgrade to reqwest 0.12.4 and rustls 0.22 (den…

024571d

…oland#24056)" (denoland#24262)" This reverts commit b94707a.

bartlomieju mentioned this pull request Jul 1, 2024

chore: upgrade to reqwest 0.12.4 and rustls 0.22 #24388

Merged

sbmsr mentioned this pull request Jul 2, 2024

sbmsr/fix 21896 validate port on serve #24398

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade to reqwest 0.12.4 and rustls 0.22 #24056

chore: upgrade to reqwest 0.12.4 and rustls 0.22 #24056

bartlomieju commented May 31, 2024 •

edited

Loading

lucacasonato commented Jun 6, 2024 •

edited

Loading

littledivy left a comment

chore: upgrade to reqwest 0.12.4 and rustls 0.22 #24056

chore: upgrade to reqwest 0.12.4 and rustls 0.22 #24056

Conversation

bartlomieju commented May 31, 2024 • edited Loading

lucacasonato commented Jun 6, 2024 • edited Loading

littledivy left a comment

Choose a reason for hiding this comment

bartlomieju commented May 31, 2024 •

edited

Loading

lucacasonato commented Jun 6, 2024 •

edited

Loading