-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable the reporting of parsing related problems when running deno lint #24332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could you add a test to tests/specs/lint/
that exercises this change?
…removed the errors number message
…i/deno into report-parse-errors
Hello @bartlomieju , |
Hello @bartlomieju , |
@HasanAlrimawi you need to update |
Signed-off-by: David Sherret <dsherret@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Supported reporting of syntax/parsing errors.
The commit is made to address issue #23437
Code changes
Added check for ParsedSource.diagnostics() and when it's not empty, all parse diagnostic errors will be logged/displayed.
PS: The change was within
fn handle_lint_result()
to log any found parse or lint diagnostic errors, since this function is called after any lint is done.