Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/crypto): make deriveBits length parameter optional and nullable #24426

Merged
merged 2 commits into from
Jul 4, 2024
Merged

feat(ext/crypto): make deriveBits length parameter optional and nullable #24426

merged 2 commits into from
Jul 4, 2024

Conversation

panva
Copy link
Contributor

@panva panva commented Jul 4, 2024

Updates SubtleCrypto.prototype.deriveBits as per w3c/webcrypto#345

(WPT update in web-platform-tests/wpt#43400)

@panva
Copy link
Contributor Author

panva commented Jul 4, 2024

cc @twiss for tracking the Deno implementation of w3c/webcrypto#345

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@panva
Copy link
Contributor Author

panva commented Jul 4, 2024

ad https://github.com/denoland/deno/actions/runs/9794490713/job/27045978642

I've updated the expectations file, when and if you update the WPT files you'll be able to adjust this again.

@littledivy littledivy merged commit f632b4a into denoland:main Jul 4, 2024
17 checks passed
@panva panva deleted the deriveBits-null branch July 4, 2024 15:41
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants