feat(ext/node): rewrite crypto keys #24463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
commented
Jul 8, 2024
There was a problem hiding this comment.
Will do this in a separate PR.
lucacasonato
force-pushed
the
rewrite_cryptokeys
branch
2 times, most recently
from
a61d2b4 to
462ebe5
Compare
|
Exciting! There are a lot of open issues that would be positively affected, if not fully resolved, by this. |
lucacasonato
force-pushed
the
rewrite_cryptokeys
branch
from
462ebe5 to
201d0a2
Compare
lucacasonato
force-pushed
the
rewrite_cryptokeys
branch
from
71fd9d7 to
2876b7a
Compare
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely rewrites how we handle key material in ext/node. Changes in this
PR:
This PR adds a lot of new individual functionality. But most importantly because
of the new key material representation, it is now trivial to add new algorithms
(as shown by this PR).
Now, when adding a new algorithm, it is also widely supported - for example
previously we supported ED25519 key pair generation, but we could not import,
export, sign or verify with ED25519. We can now do all of those things.
Fixes #20198
Fixes #21124