fix(node): better detection for when to surface node resolution errors #24653
Conversation
| @@ -0,0 +1,2 @@ | |||
| error: [ERR_MODULE_NOT_FOUND] Cannot find module 'file:///[WILDLINE]/node_modules/package/index.js' imported from 'file:///[WILDLINE]/bad_import.ts' | |||
| at file:///[WILDLINE]/bad_import.ts:1:16 | |||
There was a problem hiding this comment.
We now get node resolution errors here. This demonstrates a simple case, but imagine if this was something like exports not being resolved or the like. One issue is that the imported from '...' is repetitive because deno graph provides this information. We may want to consider removing the referrer from error messages and then only adding it when necesasry (ex. when importing esm with require)
Before:
error: Cannot find "package"
at file:///V:/deno/tests/specs/node/byonm_phantom_dep_res_failure/bad_import.ts:1:16
There was a problem hiding this comment.
I think it's fine for this pass 👍
dsherret
changed the title
| concat!( | ||
| "Could not resolve \"{}\", but found it in a package.json. ", | ||
| "Deno expects the node_modules/ directory to be up to date. ", | ||
| "Did you forget to run `npm install`?" |
There was a problem hiding this comment.
Mention DENO_FUTURE=1 deno install here as well, as per the Slack thread
There was a problem hiding this comment.
Let's land in a separate pr.
| @@ -0,0 +1,2 @@ | |||
| error: [ERR_MODULE_NOT_FOUND] Cannot find module 'file:///[WILDLINE]/node_modules/package/index.js' imported from 'file:///[WILDLINE]/bad_import.ts' | |||
| at file:///[WILDLINE]/bad_import.ts:1:16 | |||
There was a problem hiding this comment.
I think it's fine for this pass 👍
No description provided.