Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Create additional pipes for child processes #25016

Merged
merged 14 commits into from
Aug 15, 2024

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Aug 13, 2024

Linux/macos only currently.

Part of #23524 (fixes it on platforms other than windows).
Part of #16899 (fixes it on platforms other than windows).

After this PR, playwright is functional on mac/linux.

@nathanwhit nathanwhit added the ci-draft Run the CI on draft PRs. label Aug 13, 2024
@nathanwhit nathanwhit marked this pull request as ready for review August 13, 2024 17:02
@nathanwhit nathanwhit removed the ci-draft Run the CI on draft PRs. label Aug 13, 2024
@nathanwhit nathanwhit requested a review from bartlomieju August 13, 2024 20:10
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathanwhit nathanwhit merged commit 8749d65 into denoland:main Aug 15, 2024
33 checks passed
@nathanwhit nathanwhit deleted the missing-pipes branch August 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants