Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to TypeScript@next #252

Closed
wants to merge 2 commits into from

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jun 13, 2018

This PR is more advisory. Once you get to dealing with throwing errors in TypeScript, you will encounter a bug in TypeScript 2.9.1 (and in theory 2.9.3 when it is released) that will throw an exception (See: microsoft/TypeScript#24638).

This is now fixed in master and the daily builds of TypeScript, but hasn't been back ported. Therefore migrating to typescript@next will utilise the daily builds of TypeScript and avoid the issue.

Copy link
Contributor

@mohsen1 mohsen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make running yarnundetermenestic. If a new version of TypeScript is released after last time master yarn.lock was run, a dirty yarn.lock will be left behind.

@kitsonk
Copy link
Contributor Author

kitsonk commented Jun 13, 2018

@mohsen1 fair point, I have changed it to pin it to a specific the latest daily version.

@ry ry closed this Jun 13, 2018
@kitsonk kitsonk deleted the deno2-typescript-next branch July 27, 2018 01:12
hardfist pushed a commit to hardfist/deno that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants