Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/fetch): percent decode userinfo when parsing proxies #25229

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(ext/fetch): percent decode userinfo when parsing proxies #25229

merged 1 commit into from
Aug 27, 2024

Conversation

seanmonstar
Copy link
Contributor

Fixes #24691?

@seanmonstar seanmonstar changed the title fix(fetch): percent decode userinfo when parsing proxies fix(ext/fetch): percent decode userinfo when parsing proxies Aug 27, 2024
@bartlomieju bartlomieju added the backport:1.46 This PR needs to be backported to v1.46 branch label Aug 27, 2024
bartlomieju
bartlomieju approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartlomieju bartlomieju merged commit bb26fef into denoland:main Aug 27, 2024
17 checks passed
lucacasonato pushed a commit that referenced this pull request Aug 29, 2024
@seanmonstar @lucacasonato
fix(ext/fetch): percent decode userinfo when parsing proxies (#25229)
27edafa 
Fixes #24691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
backport:1.46 This PR needs to be backported to v1.46 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.45.3 breaks proxy env variables impact on deno upgrade
2 participants
@seanmonstar @bartlomieju