Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require(esm) #25501

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: require(esm) #25501

merged 1 commit into from
Sep 10, 2024

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Sep 7, 2024

implement require(esm) using op_import_sync from deno_core.

possible future changes:

  • cts and mts
  • replace Deno.core.evalContext to optimize esm syntax detection

Fixes: #25487

@devsnek devsnek force-pushed the import-sync branch 2 times, most recently from c446b03 to 0bcdbad Compare September 9, 2024 21:57
@devsnek devsnek added the ci-draft Run the CI on draft PRs. label Sep 9, 2024
@devsnek devsnek force-pushed the import-sync branch 5 times, most recently from c1bcb5f to 12f0401 Compare September 10, 2024 18:13
@devsnek devsnek marked this pull request as ready for review September 10, 2024 18:13
@devsnek devsnek removed the ci-draft Run the CI on draft PRs. label Sep 10, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@devsnek devsnek closed this Sep 10, 2024
@devsnek devsnek reopened this Sep 10, 2024
@devsnek devsnek enabled auto-merge (squash) September 10, 2024 19:36
@devsnek devsnek merged commit f9007d3 into main Sep 10, 2024
33 checks passed
@devsnek devsnek deleted the import-sync branch September 10, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for require(esm)
3 participants