Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Float16Array type #25506

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

petamoriken
Copy link
Contributor

No description provided.

@@ -4803,7 +4803,7 @@ declare interface Float16 {
* @experimental
*/
declare interface Float16Constructor {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this one be Float16ArrayConstructor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartlomieju bartlomieju merged commit d9b5bcc into denoland:main Sep 9, 2024
17 checks passed
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Sep 9, 2024
@petamoriken petamoriken deleted the fix/float16array-type branch September 10, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants