Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(net): remove Deno.ConnectTlsOptions.{certChain,certFile,privateKey} and Deno.ListenTlsOptions.certChain,certFile,keyFile} #25525

Merged
merged 9 commits into from
Sep 10, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 9, 2024

Towards #22079

…vateKey}` and `Deno.ListenTlsOptions.certChain,certFile,keyFile}`
@iuioiua iuioiua added the ci-draft Run the CI on draft PRs. label Sep 9, 2024
@iuioiua iuioiua marked this pull request as ready for review September 9, 2024 07:49
@iuioiua iuioiua removed the ci-draft Run the CI on draft PRs. label Sep 9, 2024
@iuioiua iuioiua marked this pull request as draft September 10, 2024 05:32
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@iuioiua iuioiua marked this pull request as ready for review September 10, 2024 12:01
@iuioiua iuioiua enabled auto-merge (squash) September 10, 2024 12:01
@iuioiua iuioiua merged commit ace1202 into denoland:main Sep 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants