ci: Fix uploading latest canary version #25725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyarohith
reviewed
Sep 19, 2024
| - name: Clone repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 50 |
lucacasonato
approved these changes
Sep 19, 2024
satyarohith
approved these changes
Sep 19, 2024
The requirement is that CI was broken in the past 2 days, because we only fetched last 5 commits. So when I fixed the original problem the canary was still not uploaded because the latest canary on dl.deno.land was like ~20 commits back and it was not present in git history - so we script thought that a newer version is already available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.