Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move NpmCacheDir to deno_cache_dir #25916

Merged
merged 7 commits into from
Sep 28, 2024
Merged

refactor: move NpmCacheDir to deno_cache_dir #25916

merged 7 commits into from
Sep 28, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Sep 27, 2024 •
edited
Loading

Part of the ongoing work to move more of Deno's resolution out of the CLI crate (for use in Wasm and other things)

Includes:

dsherret
dsherret commented Sep 27, 2024
View reviewed changes
cli/npm/managed/mod.rs
@@ -188,6 +189,7 @@ fn create_inner(
fn create_cache(options: &CliNpmResolverManagedCreateOptions) -> Arc<NpmCache> {
Arc::new(NpmCache::new(
NpmCacheDir::new(
&DenoCacheEnvFsAdapter(options.fs.as_ref()),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a correctness fix here. I don't think the previous mistake of using the actual fs had any impact IRL though.

@dsherret dsherret mentioned this pull request Sep 27, 2024
Merged
bartlomieju
bartlomieju approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup

@dsherret dsherret merged commit 1bb4780 into denoland:main Sep 28, 2024
17 checks passed
@dsherret dsherret deleted the feat_npm_cache_dir_from_deno_cache_dir branch September 28, 2024 12:50
dsherret added a commit that referenced this pull request Sep 28, 2024
@dsherret
refactor: extract out sloppy imports resolution from CLI crate (#25920)
5faf769 
This is slow progress towards creating a `deno_resolver`  crate.

Waiting on:

* #25918
* #25916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju