fix(add): only add npm deps to package.json if it's at least as close as deno.json #26683

nathanwhit · 2024-11-01T21:14:58Z

cli/tools/registry/pm.rs

dsherret

LGTM!

… as deno.json (#26683) Fixes #26653

prefer package.json for npm defs if not farther

fd5de5d

nathanwhit requested review from dsherret and bartlomieju November 1, 2024 21:14

nathanwhit changed the title ~~fix(add): only put npm deps into package.json if it's at least as close as the nearest deno.json~~ fix(add): only add npm deps to package.json if it's at least as close as the nearest deno.json Nov 1, 2024

nathanwhit changed the title ~~fix(add): only add npm deps to package.json if it's at least as close as the nearest deno.json~~ fix(add): only add npm deps to package.json if it's at least as close as deno.json Nov 1, 2024

ry reviewed Nov 1, 2024

View reviewed changes

cli/tools/registry/pm.rs Outdated Show resolved Hide resolved

add comment

fb63b71

dsherret approved these changes Nov 2, 2024

View reviewed changes

nathanwhit merged commit 2c8a0e7 into denoland:main Nov 2, 2024
17 checks passed

nathanwhit deleted the prefer-npm-distance branch November 2, 2024 02:10

bartlomieju pushed a commit that referenced this pull request Nov 5, 2024

fix(add): only add npm deps to package.json if it's at least as close…

01c4a2e

… as deno.json (#26683) Fixes #26653

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(add): only add npm deps to package.json if it's at least as close as deno.json #26683

fix(add): only add npm deps to package.json if it's at least as close as deno.json #26683

nathanwhit commented Nov 1, 2024

dsherret left a comment

fix(add): only add npm deps to package.json if it's at least as close as deno.json #26683

fix(add): only add npm deps to package.json if it's at least as close as deno.json #26683

Conversation

nathanwhit commented Nov 1, 2024

dsherret left a comment

Choose a reason for hiding this comment