feat: permission stack traces in ops #26938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
commented
Nov 20, 2024
| @@ -3316,6 +3317,8 @@ fn permission_args(app: Command, requires: Option<&'static str>) -> Command { | |||
| <p(245)>--deny-run | --deny-run="whoami,ps"</> | |||
| <g>--deny-ffi[=<<PATH>...]</> (Unstable) Deny loading dynamic libraries. Optionally specify denied directories or files. | |||
| <p(245)>--deny-ffi | --deny-ffi="./libfoo.so"</> | |||
| <g>DENO_TRACE_PERMISSIONS</> Environmental variable to enable stack traces in permission prompts. | |||
| <p(245)>DENO_TRACE_PERMISSIONS=1 deno run main.ts</> | |||
There was a problem hiding this comment.
added twice, once to the env docs and once to the perm docs for visibility
bartlomieju
requested changes
Nov 20, 2024
bartlomieju
reviewed
Nov 20, 2024
bartlomieju
reviewed
Nov 20, 2024
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Nov 20, 2024
This commit improves permission prompts by adding an option to print a full trace of where the permissions is being requested. Due to big performance hint of stack trace collection, this is only enabled when `DENO_TRACE_PERMISSIONS` env var is present. Closes denoland#20756 --------- Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves permission prompts by adding an option
to print a full trace of where the permissions is being requested.
Due to big performance hint of stack trace collection, this is only
enabled when
DENO_TRACE_PERMISSIONSenv var is present.Closes #20756