Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): support private key export in JWK format #27325

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

bartlomieju
Copy link
Member

Closes #26643

@codegod100
Copy link

waiting on this so I can use node atproto oauth lib with deno

@technoY2K
Copy link

Bumping this, I am also blocked from using atproto oauth in deno. Is there a work-around while we wait for this PR?

@littledivy littledivy marked this pull request as ready for review December 31, 2024 11:04
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 1cd3600 into denoland:main Dec 31, 2024
17 checks passed
@bartlomieju bartlomieju deleted the node_jwk branch December 31, 2024 12:49
@technoY2K
Copy link

Nice! Thank you @bartlomieju and @littledivy

Not 100% sure how this works from here. Now that its merged into main, do we need to wait for a release and then update deno?

@littledivy
Copy link
Member

Yep, you can try it out now using canary builds (deno upgrade --canary) or wait for a patch release.

@technoY2K
Copy link

Yep, you can try it out now using canary builds (deno upgrade --canary) or wait for a patch release.

I will try that, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to export private key in jwk format
4 participants