fix(node): Prevent node:child_process from always inheriting the parent environment (#27343) #27340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TateKennington
changed the title
|
Hi @nathanwhit, could I please get a review on this if you have the time? 😄 (Sorry for the ping, I wasn't sure how best to request a review / who to ask, your name was just in the Git blame most recently 😅) |
nathanwhit
approved these changes
Jan 13, 2025
bartlomieju
pushed a commit
that referenced
this pull request
Jan 16, 2025
…nt environment (#27343) (#27340) Fixes #27343 Currently the node:child_process polyfill is always passing the full parent environment to all spawned subprocesses. In the case where `options.env` is provided those keys are overridden but the rest of the parent environment is still passed through. On Node the behaviour is for child processes to only inherit the parent environment when `options.env` isn't specified. When `options.env` is specified the child process inherits only those keys. This PR updates the internal node child_process polyfill so that the `clearEnv` argument is set to true when spawning the subprocess to prevent the parent environment always being inherited by default. It also fixes an issue where `normalizeSpawnArguments` wasn't returning the `env` option if `options.env` was unset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27343
Currently the node:child_process polyfill is always passing the full parent environment to all spawned subprocesses. In the case where
options.envis provided those keys are overridden but the rest of the parent environment is still passed through.On Node the behaviour is for child processes to only inherit the parent environment when
options.envisn't specified. Whenoptions.envis specified the child process inherits only those keys.This PR updates the internal node child_process polyfill so that the
clearEnvargument is set to true when spawning the subprocess to prevent the parent environment always being inherited by default. It also fixes an issue wherenormalizeSpawnArgumentswasn't returning theenvoption ifoptions.envwas unset.