feat(unstable): no config npm:@opentelemetry/api integration #27541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
no_config_otel
branch
from
e262645 to
a9fc986
Compare
This commit adds the needed configuration to let npm:@opentelemetry/api pick up trace, metrics, and context providers automatically.
lucacasonato
force-pushed
the
no_config_otel
branch
from
a9fc986 to
b2af0f5
Compare
devsnek
reviewed
Jan 6, 2025
| @@ -1102,6 +1107,19 @@ export function bootstrap( | |||
| default: | |||
| break; | |||
| } | |||
|
|
|||
| if (TRACING_ENABLED || METRICS_ENABLED) { | |||
There was a problem hiding this comment.
if these are turned off, does this turn all otel usage into noops, or does it raise an error about them being missing?
devsnek
approved these changes
Jan 6, 2025
dsherret
pushed a commit
that referenced
this pull request
Jan 9, 2025
After this PR, one does not need to import `jsr:@deno/otel` anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, one does not need to import
jsr:@deno/otelanymore.Depends on #27473