Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(node_resolver): make conditions_from_resolution_mode configurable #27596
refactor(node_resolver): make conditions_from_resolution_mode configurable #27596
Changes from 23 commits
31e16e2
35c627a
d7ffef8
b925228
d21a902
fc0f5d6
7b25307
460fcaa
0188efc
fdf915a
555fae3
56edca4
a081d2c
86ca545
656da92
bc1fcd1
91fef55
6d491b6
3a06e2c
ba4f7b2
a686645
fbd4b63
0a2fda4
ec8447c
deb26e2
8797417
ee8aae7
f513538
12f061a
2a1baad
1706cab
f39faeb
7ee74bd
e0e3338
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should just be:
pub struct ConditionsFromResolutionMode(Option<Box<dyn Fn(ResolutionMode) -> &'static [&'static str]>>)
with a default implementation ofConditionsFromResolutionMode(None)
that will instead usedeno_conditions_from_resolution_mode
? That way the other code can just doConditionsFromResolutionMode::default()
instead of needing to know aboutdeno_conditions_from_resolution_mode