refactor(npm): move InNpmPackageChecker code to deno_resolver
#27609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jan 9, 2025
| @@ -20,7 +23,7 @@ pub struct NpmPackageFsResolverPackageFolderError(deno_semver::StackString); | |||
|
|
|||
| /// Part of the resolution that interacts with the file system. | |||
| #[async_trait(?Send)] | |||
| pub trait NpmPackageFsResolver: Send + Sync { | |||
| pub trait NpmPackageFsResolver: MaybeSend + MaybeSync { | |||
There was a problem hiding this comment.
Also included some fixes to get this crate compiling when not using the sync feature.
bartlomieju
approved these changes
Jan 9, 2025
| @@ -20,7 +23,7 @@ pub struct NpmPackageFsResolverPackageFolderError(deno_semver::StackString); | |||
|
|
|||
| /// Part of the resolution that interacts with the file system. | |||
| #[async_trait(?Send)] | |||
| pub trait NpmPackageFsResolver: Send + Sync { | |||
| pub trait NpmPackageFsResolver: MaybeSend + MaybeSync { | |||
dsherret
added a commit
that referenced
this pull request
Jan 9, 2025
As title. Will allow consumers to create this struct and use our behaviour. Closes #27409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Will allow consumers to create this struct and use our behaviour.
Closes #27409