fix(ext/node): apply @npmcli/agent workaround to npm-check-updates
#27639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyarohith
approved these changes
Jan 13, 2025
bartlomieju
pushed a commit
that referenced
this pull request
Jan 16, 2025
#27639) See the comment #25470 (comment) for the reason why we do this workaround to make `make-fetch-happen` work in Deno This PR applies the same workaround to `npm-check-updates` package. `npm-check-updates` internally uses [`npm-registry-fetch`](https://www.npmjs.com/package/npm-registry-fetch) which uses [`make-fetch-happen`](https://www.npmjs.com/package/make-fetch-happen) (the problematic package) for making http request to npm registry. The detection of `make-fetch-happen` doesn't work for `npm-check-updates` because we use call stack at `net.Socket` constructor to check if it's called from `make-fetch-happen`, but `npm-check-updates` bundles its dependency and the check doesn't work. This PR adds the check of `npm-check-updates` string in call stack in net.Socket constructor to trigger the workaroud. closes #27629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comment #25470 (comment) for the reason why we do this workaround to make
make-fetch-happenwork in DenoThis PR applies the same workaround to
npm-check-updatespackage.npm-check-updatesinternally usesnpm-registry-fetchwhich usesmake-fetch-happen(the problematic package) for making http request to npm registry.The detection of
make-fetch-happendoesn't work fornpm-check-updatesbecause we use call stack atnet.Socketconstructor to check if it's called frommake-fetch-happen, butnpm-check-updatesbundles its dependency and the check doesn't work.This PR adds the check of
npm-check-updatesstring in call stack in net.Socket constructor to trigger the workaroud.closes #27629