fix(ext/node): propagate socket error to client request object #27678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyarohith
reviewed
Jan 16, 2025
Co-authored-by: Satya Rohith <me@satyarohith.com> Signed-off-by: Yoshiya Hinosawa <stibium121@gmail.com>
kt3k
deleted the
fix-node-http-propagete-socket-error-http-request-object
branch
crowlKats
pushed a commit
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Satya Rohith <me@satyarohith.com> (cherry picked from commit 339bc44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the 2nd part of #27670
Currently if socket errors with DNS error, then there's no way to handle it and it becomes uncaught error. This PR propagate it to ClientRequest object and the error can be handled with 'error' event listener on it.