Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install/global): remove importMap field from specified config file #27744

Merged

Conversation

dsherret
Copy link
Member

Closes #27734

@dsherret dsherret merged commit 0d3d4f5 into denoland:main Jan 20, 2025
17 checks passed
@dsherret dsherret deleted the fix_remove_import_map_field_specified_config branch January 20, 2025 21:50
crowlKats pushed a commit that referenced this pull request Jan 21, 2025
if let Some(new_text) = remove_import_map_field_from_text(&config_text) {
if flags.import_map_path.is_none() {
log::warn!(
"{} \"importMap\" field in the specified config file we be ignored. Use the --import-map flag instead.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"file we be ignored" 🤔
typo 😋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to override importMap config with --import-map flag in deno install
3 participants