-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(unstable/temporal): implement Temporal.ZonedDateTime.getTimeZoneTransition
#27770
fix(unstable/temporal): implement Temporal.ZonedDateTime.getTimeZoneTransition
#27770
Conversation
02b2914
to
ee7293d
Compare
ee7293d
to
be7d981
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this implementation based on some existing code?
The parameter parsing of |
Sorry for a slow response @printfn; we're just working on upgrading to V8 13.4 - I'm not sure, but maybe it already implements this functionality? If not we can still land it. |
Makes sense, though based on https://github.com/search?q=repo%3Av8%2Fv8+getTimeZoneTransition&type=code I don't think v8 implements this yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This patches Temporal to support the
getTimeZoneTransition
method onZonedDateTime
.See #27731.