-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove tsc snapshot #27987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but how hard is it to get this using the code cache?
Edit: I read the description now.
Let's wait with merging until we have |
cli/build.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's go once the conflicts are resolved
This reverts commit 174e496.
…land#28052)" This reverts commit acdc7dc.
Removes the TSC snapshot to unblock the V8 upgrade (which enables shared RO heap, and is incompatible with multiple snapshots).
this compresses the sources and declaration files as well, which leads to a roughly 4.2MB reduction in binary size.
this currently adds about 80ms to deno check times, but code cache isn't wired up for the extension code (namely
00_typescript.js
) yet