fix(ext/node): implement StatementSync#iterate #28168
Merged
+160
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
approved these changes
Feb 18, 2025
bartlomieju
reviewed
Feb 18, 2025
| scope: &mut v8::HandleScope<'a>, | ||
| #[varargs] params: Option<&v8::FunctionCallbackArguments>, | ||
| ) -> Result<v8::Local<'a, v8::Object>, SqliteError> { | ||
| macro_rules! v8_static_strings { |
There was a problem hiding this comment.
We should just export this from deno_core - this is the third place we're redefining this macro
tests/unit_node/sqlite_test.ts
Outdated
Comment on lines
207
to
209
| for (const row of stmt.iterate()) { | ||
| result.push(row); | ||
| } |
There was a problem hiding this comment.
Won't it crash/error if you try to iterate again? Can you add a test for that?
bartlomieju
approved these changes
Feb 18, 2025
NfNitLoop
reviewed
Mar 6, 2025
| Deno.test("[node/sqlite] StatementSync#iterate", () => { | ||
| const db = new DatabaseSync(":memory:"); | ||
| const stmt = db.prepare("SELECT 1 UNION ALL SELECT 2 UNION ALL SELECT 3"); | ||
| // @ts-ignore: types are not up to date |
There was a problem hiding this comment.
Did y'all forget to eventually add these in? 😅
I'm able to call stmt.iterate() in Deno 2.2.3, but the types are not present so deno check fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28130