fix(lint): plugins ignored when no rust rule active #28269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Feb 24, 2025
dsherret
reviewed
Feb 24, 2025
| @@ -289,10 +290,11 @@ impl WorkspaceLinter { | |||
| let exclude = lint_options.rules.exclude.clone(); | |||
|
|
|||
| let plugin_specifiers = lint_options.plugins.clone(); | |||
| let lint_rules = self.lint_rule_provider.resolve_lint_rules_err_empty( | |||
There was a problem hiding this comment.
It looks like linting stdin is not taking into account plugins?
There was a problem hiding this comment.
yeah Noticed that as well. It seems like there we don't support plugins yet.
littledivy
pushed a commit
that referenced
this pull request
Feb 25, 2025
When all Rust-based rules where filtered out we were bailing out early instead of checking if there are plugin rules we need to run. This meant we errored out with a "No lint rules to run" message, even though plugin rules were active. Fixes #28267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all Rust-based rules where filtered out we were bailing out early instead of checking if there are plugin rules we need to run. This meant we errored out with a "No lint rules to run" message, even though plugin rules were active.
Fixes #28267