Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): give access to SourceCode in 'deno test' #28278

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix(lint): give access to SourceCode in 'deno test' #28278

merged 1 commit into from
Feb 24, 2025

Conversation

bartlomieju
Copy link
Member

Closes #28273

marvinhagemeister
marvinhagemeister approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I totally forgot that we need to store the ops in a var eagerly

@bartlomieju bartlomieju requested review from dsherret and removed request for dsherret February 24, 2025 15:40
dsherret
dsherret approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 93a1bb7 into denoland:main Feb 24, 2025
18 checks passed
@bartlomieju bartlomieju deleted the lint_access_to_source_in_test branch February 24, 2025 16:21
littledivy pushed a commit that referenced this pull request Feb 25, 2025
@bartlomieju @littledivy
fix(lint): give access to SourceCode in 'deno test' (#28278)
1d0462b 
Closes #28273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lint: Deno.lint.SourceCode.text causes error: TypeError: op_lint_get_source is not a function
3 participants
@bartlomieju @marvinhagemeister @dsherret