Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unstable): lint plugin fix :has(), :is/where/matches and :not() selectors #28348

Merged
merged 3 commits into from
Mar 4, 2025
Merged

fix(unstable): lint plugin fix :has(), :is/where/matches and :not() selectors #28348

merged 3 commits into from
Mar 4, 2025
+361 −34

Conversation

marvinhagemeister
Copy link
Contributor

@marvinhagemeister marvinhagemeister commented Feb 28, 2025 •
edited
Loading

This PR adds support for :has/:is/:where() and :not(). The latter was already present, but found a bunch of issues with it and I'd say that it didn't really work before this PR.

Fixes #28335

@marvinhagemeister
Copy link
Contributor Author

marvinhagemeister commented Feb 28, 2025 •
edited
Loading

Wait, looks like I got :is() and :where() wrong. I'll look into it. - Fixed

@marvinhagemeister marvinhagemeister marked this pull request as draft February 28, 2025 17:14
@marvinhagemeister marvinhagemeister requested review from nathanwhit and littledivy and removed request for bartlomieju March 3, 2025 08:29
@marvinhagemeister
Copy link
Contributor Author

Fixed :is() and :where(). Also added :matches() as an alias since that's used in typescript-eslint.

@marvinhagemeister marvinhagemeister marked this pull request as ready for review March 3, 2025 08:29
@marvinhagemeister marvinhagemeister changed the title feat(unstable): lint plugin fix :has() and :not() selectors fix(unstable): lint plugin fix :has() and :not() selectors Mar 3, 2025
@marvinhagemeister marvinhagemeister changed the title fix(unstable): lint plugin fix :has() and :not() selectors fix(unstable): lint plugin fix :has(), :is/where/matches and :not() selectors Mar 3, 2025
littledivy
littledivy approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@marvinhagemeister marvinhagemeister merged commit 1f6f561 into main Mar 4, 2025
18 checks passed
@marvinhagemeister marvinhagemeister deleted the lint-has-is branch March 4, 2025 15:04
littledivy pushed a commit that referenced this pull request Mar 5, 2025
@marvinhagemeister @littledivy
fix(unstable): lint plugin fix :has(), :is/where/matches and `:no…
20f1fb1 
…t()` selectors (#28348)

This PR adds support for `:has/:is/:where()` and `:not()`. The latter
was already present, but found a bunch of issues with it and I'd say
that it didn't really work before this PR.


Fixes #28335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint Plugin - Support :is() and :has()
2 participants
@marvinhagemeister @littledivy