feat: Alternate dispatch infra #2939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
force-pushed
the
feat-alternate_dispatch
branch
2 times, most recently
from
2b3c348 to
a0b270c
Compare
bartlomieju
commented
Sep 13, 2019
cli/ops/dispatcher.rs
Outdated
| H: Copy + 'static, | ||
| { | ||
| pub op_registry: RwLock<BTreeMap<OpId, H>>, | ||
| pub name_registry: RwLock<BTreeMap<String, OpId>>, |
There was a problem hiding this comment.
Since op_id is effectively an offset we could try with Vec instead of BTreeMap
bartlomieju
force-pushed
the
feat-alternate_dispatch
branch
2 times, most recently
from
d88f66e to
62c3613
Compare
bartlomieju
force-pushed
the
feat-alternate_dispatch
branch
from
62c3613 to
840e67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative take on #2785 - instead of implementing ops as traits they are functions with defined signature that are registered during startup.
I got registration of ops working - it is done in
denoMain.For now there are two hard coded dispatchers -
minimalandjson.Dispatchers code definitely needs deduplication and abstraction into trait.This is still very early prototype.
CC @afinch7 @ry