Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix js/url #3316

Merged
merged 1 commit into from
Nov 12, 2019
Merged

fix js/url #3316

merged 1 commit into from
Nov 12, 2019

Conversation

zhmushan
Copy link
Contributor 

> new URL(“about:blank”)

expected:

{ href: “about:blank”, protocol: “about:”, origin: “null”, ... }

actual:

{ href: “about://blank”, protocol: “about:”, origin: “about://”, ... }

> new URL(“0.0.0.0:8080”)

expected: Error
actual:

{ href: “0.0.0.0://8080”, ... }

ry
ry approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 0f33bf6 into denoland:master Nov 12, 2019
@zhmushan zhmushan deleted the fixurl branch November 13, 2019 00:25
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@zhmushan @bartlomieju
fix url parse bug (denoland#3316)
c469dd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhmushan @ry