feat: deno_std node addition #3319
Conversation
std/node/README.md
Outdated
| # Deno Node compatibility | ||
|
|
||
| This module is meant to have a compatibility layer for the | ||
| [nodeJS standard library](https://nodejs.org/docs/latest-v11.x/api/). |
There was a problem hiding this comment.
this should be TLS version
There was a problem hiding this comment.
There is no link directly pointing to LTS version, updated it to aim v12 as it's LTS: https://nodejs.org/en/
|
@axetroy Actually there was some basic discussion in Gitter chatroom. |
std/node/util.ts
Outdated
| isObject, | ||
| isError, | ||
| isFunction | ||
| } from "./util/main.ts"; |
There was a problem hiding this comment.
Let's change this from main.ts to mod.ts.
I am not quite sure if we should reexpose mod as std/node/util.ts or just leave as std/node/util/mod.ts. The latter follows our recommendation better, while the former might seem more familiar to node users...
There was a problem hiding this comment.
mod.ts seems better yes.
Regarding the exposure it's more like a taste, you have 2 solutions
import { fs } from 'std/node' or import { readfile } from 'std/node/fs' i'm ok with both
std/node/README.md
Outdated
| This module is meant to have a compatibility layer for the | ||
| [nodeJS standard library](https://nodejs.org/docs/latest-v11.x/api/). | ||
|
|
||
| **Warning** : Any function of this module do not have to be refered anywhere in |
There was a problem hiding this comment.
I assume this is "should not" instead of "do not have to"?
std/node should be able to import utilities from other std modules, but not the other way around IMO.
There was a problem hiding this comment.
I assume this is "should not" instead of "do not have to"?
std/node should be able to import utilities from other std modules, but not the other way around IMO.
that's what i was meaning. Sorry for my engrish
Ref: https://gitter.im/denolife/Lobby?at=5dbda5dbe1c5e915081e2729 |
std/node/fs.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export { readFile, readFileSync } from "./fs/read_file.ts"; | |||
There was a problem hiding this comment.
Maybe just merge read_file.ts into this one - it will make for better docs on Deno.land and also I prefer to keep the number of files small until it becomes unwieldy to have so many functions in a single file - at that point we can break it out. So just fs.ts and fs_test.ts please.
There was a problem hiding this comment.
it was just a direct port but i get your point.
std/node/util/main_test.ts
Outdated
| @@ -0,0 +1,122 @@ | |||
| import { test } from "../../testing/mod.ts"; | |||
| import { assert } from "../../testing/asserts.ts"; | |||
| import * as util from "./main.ts"; | |||
There was a problem hiding this comment.
main.ts ? I don’t think we should use the file name main.ts in std/node ...
There was a problem hiding this comment.
Yeah, direct port, i'll change this as mentionned in the other comment
Moving the https://github.com/denolib/node to deno_std.
ref #2644