Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor std/types #4713

Merged
merged 6 commits into from
Apr 13, 2020
Merged

Refactor std/types #4713

merged 6 commits into from
Apr 13, 2020

Conversation

Soremwar
Copy link
Contributor

@Soremwar Soremwar commented Apr 11, 2020

This is part of a series of commit aimed to organize std/types for a production environment

  • Refactor folders
  • Add README for every library
  • Correctly set up library versions

Progress can be tracked in #4712

@Soremwar Soremwar mentioned this pull request Apr 11, 2020
4 tasks
@Soremwar Soremwar changed the title [WIP] Refactor std/types Refactor std/types Apr 11, 2020
@kitsonk
Copy link
Contributor

kitsonk commented Apr 11, 2020

I would avoid copying the semver directly, because that would indicate to people that there is some level of support for semver resolution here, there isn't and we don't want to have every version. I would really leave it as a simple v tag, if it needs it.

Also, upon reflection, I suspect we could use csstype directly off of a CDN, like unpkg. There is no need to maintain it here.

@Soremwar
Copy link
Contributor Author

@kitsonk Done

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Soremwar
Copy link
Contributor Author

@kitsonk Any other comments?

@ry ry merged commit 8397cd5 into denoland:master Apr 13, 2020
@Soremwar Soremwar deleted the std_types branch April 19, 2020 17:24
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants