remove more calls to futures::executor::block_on #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ry
reviewed
Apr 16, 2020
| std_file_resource(&mut state.resource_table, rid, move |r| match r { | ||
| Ok(std_file) => std_file.try_clone().map_err(OpError::from), | ||
| Err(_) => Err(OpError::bad_resource_id()), | ||
| }) | ||
| } |
There was a problem hiding this comment.
If one clones a file, should there be a new entry in the resource table?
There was a problem hiding this comment.
No - it's same underlying file - we clone just because of API contract that requires Into<Stdio> which requires owned file.
There was a problem hiding this comment.
Hm. I'm not sure about this, but this is probably better than before. Let's land it for now and I'll revisit later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[tokio::test]insteadstd_file_resourcehelperset_raw- used raw handles/fds