Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from dprint-ignore to deno-fmt-ignore #5659

Merged
merged 2 commits into from
May 27, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented May 20, 2020

The latest version of dprint supports a custom ignore string, which @dsherret set to deno-fmt-ignore, so for deno fmt we need to migrate to // deno-fmt-ignore.

I don't know if there is any docs we need to update or not...

@bartlomieju
Copy link
Member

When we're gonna switch to dprint for internal formatting we will probably use dprint-ignore instead of deno-fmt-ignore - after all we'll be using standalone dprint CLI instead of deno fmt.

@dsherret
Copy link
Member

@bartlomieju most likely your config will have ”deno”: true which causes it to use deno-fmt-ignore so I think you’ll end having it almost exactly like deno fmt even though the dprint cli is running it.

@bartlomieju
Copy link
Member

@bartlomieju most likely your config will have ”deno”: true which causes it to use deno-fmt-ignore so I think you’ll end having it almost exactly like deno fmt even though the dprint cli is running it.

Thanks for explanation @dsherret 👍 then I agree we should land it

@kitsonk kitsonk force-pushed the deno-fmt-ignore branch from 5f1bc97 to f462a94 Compare May 27, 2020 05:27
@kitsonk
Copy link
Contributor Author

kitsonk commented May 27, 2020

@bartlomieju all green now/again

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit ebae1a2 into denoland:master May 27, 2020
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jun 5, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants